Simplify recognize digits example code #10722

kexinzhao · 2018-05-16T23:35:43Z

Lines 257 to 272 in b67ce35

    
           def _test_by_executor(self, reader, feed_order, fetch_list): 
        
               with executor.scope_guard(self.scope): 
        
                   feed_var_list = build_feed_var_list(self.test_program, feed_order) 
        
                   feeder = data_feeder.DataFeeder( 
        
                       feed_list=feed_var_list, place=self.place) 
        
                   exe = executor.Executor(self.place) 
        
                   accumulated = len(fetch_list) * [0] 
        
                   count = 0 
        
                   for data in reader(): 
        
                       outs = exe.run(program=self.test_program, 
        
                                      feed=feeder.feed(data), 
        
                                      fetch_list=fetch_list) 
        
                       accumulated = [x[0] + x[1][0] for x in zip(accumulated, outs)] 
        
                       count += 1 
        
                   return [x / count for x in accumulated]

The code above returns a list of float scalars to test_metrics as follows:
test_metrics = trainer.test(xxx)

Thus if we use avg_cost, acc = trainer.test(xxx) instead, both avg_cost and acc would be a Python float scalar.

Hence we don't need the numpy.array(acc_set).mean() and the code can be simplified.

daming-lu

Thanks for the changes 👍

simplify recognize digits example code

8f68e95

kexinzhao requested a review from daming-lu May 16, 2018 23:35

daming-lu approved these changes May 17, 2018

View reviewed changes

daming-lu merged commit bbd7580 into PaddlePaddle:develop May 17, 2018

kexinzhao deleted the simplify_code branch May 17, 2018 19:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simplify recognize digits example code #10722

Simplify recognize digits example code #10722

kexinzhao commented May 16, 2018

daming-lu left a comment

	def _test_by_executor(self, reader, feed_order, fetch_list):
	with executor.scope_guard(self.scope):
	feed_var_list = build_feed_var_list(self.test_program, feed_order)
	feeder = data_feeder.DataFeeder(
	feed_list=feed_var_list, place=self.place)
	exe = executor.Executor(self.place)
	accumulated = len(fetch_list) * [0]
	count = 0
	for data in reader():
	outs = exe.run(program=self.test_program,
	feed=feeder.feed(data),
	fetch_list=fetch_list)
	accumulated = [x[0] + x[1][0] for x in zip(accumulated, outs)]
	count += 1

	return [x / count for x in accumulated]

Simplify recognize digits example code #10722

Simplify recognize digits example code #10722

Conversation

kexinzhao commented May 16, 2018

daming-lu left a comment

Choose a reason for hiding this comment